Normalize on py_foo()
and foo()
function name pattern in accelerate
crate
#12936
Labels
good first issue
Good for newcomers
Rust
This PR or issue is related to Rust code in the repository
type: feature request
New feature or request
What should we add?
In the accelerate crate when we have a split between a python facing function and a rust entrypoint for internal reuse we typically used the pattern where the rust function was named
foo_inner()
and thepyfunction
was namedfoo()
. For example:https://github.com/Qiskit/qiskit/blob/main/crates/accelerate/src/dense_layout.rs#L101-L130
However in the circuit crate we started using a different pattern, where the pyfunction was named
py_foo
and the name attribute on thepyfunction
macro was the name without thepy
prefix. As we're writing an increasing amount of rust code this seems like a better pattern. So we should migrate the accelerate crate to follow the same pattern internally.The text was updated successfully, but these errors were encountered: