Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug - extract datetime lowercases remainder #147

Open
JarbasAl opened this issue Nov 2, 2020 · 1 comment
Open

bug - extract datetime lowercases remainder #147

JarbasAl opened this issue Nov 2, 2020 · 1 comment
Labels
bug Something isn't working en relates to english language

Comments

@JarbasAl
Copy link
Collaborator

JarbasAl commented Nov 2, 2020

the remainder text should not be lowercased, this impacts comparisons between remainder and original utterance

similar to #145 which has been fixed in #146

will fix this in the datetime rewrite #74

@JarbasAl JarbasAl added the bug Something isn't working label Nov 2, 2020
@JarbasAl JarbasAl added the en relates to english language label Nov 2, 2020
@ChanceNCounter
Copy link
Contributor

I think this can be addressed without much of a performance hit by way of rolling token replacement. The alternative, iterating over the original and replacing only the chunks where this_chunk != original.lower(), obviously doesn't scale well to large inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working en relates to english language
Projects
None yet
Development

No branches or pull requests

2 participants