Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Loop Carb History ICE Screen Timeline #1861

Open
flyingpie101 opened this issue Dec 7, 2022 · 29 comments · May be fixed by #2182
Open

Increase Loop Carb History ICE Screen Timeline #1861

flyingpie101 opened this issue Dec 7, 2022 · 29 comments · May be fixed by #2182

Comments

@flyingpie101
Copy link

flyingpie101 commented Dec 7, 2022

Is your feature request related to a problem? Please describe.
No technical problem at all. It is purely a functional usage problem.
As a caregiver to a young Looper (12 years old), I am finding her/our carb counting and impact still very much a learning game. The ICE screen is very helpful in gauging carb impacts retroactively. The problem is, with respect to supper and evening snacks, that often have fat/protein impacts, that we are not able to view the impacts until after midnight (when we are sleeping)
In order to see what is/has happening/ed, i would be required to go into her room at 2am, launch Loop, go to ICE, take screenshots, etc....
In the morning when we wake up, all the data is gone.

Describe the solution you'd like
I would like to see something like, the current view able to display the last 24 hours of data.
Otherwise, perhaps a new tab that shows the previous day's snapshot, maybe a day could be between 5am and 5am+24h, as opposed to 12am

Describe alternatives you've considered
The only other alternative is Nightscout reports. Which I find is similar but much harder to read (for me). And way beyond a child's understanding.

Additional context
Previous Issues
#681
#840

Previous PR (later deleted I believe)
#738

@darrelld3
Copy link

darrelld3 commented Dec 7, 2022 via email

@blameitonben
Copy link

blameitonben commented Dec 7, 2022 via email

@flyingpie101
Copy link
Author

I use sugarmate, works well for this use case.

I also use Sugarmate ? Where do you see Carbs absorbed vs entered ?

@flyingpie101
Copy link
Author

I am specifically referring to the seeing the ICE screen, where you may have entered 40g carbs for a meal at 3 hours. But 4.5hours later, loop will show 45g carbs observed. Which I love.
My problem is having a late supper at 7pm with a 5-6 hours absorption. The observed isn't fully available until 8-9 hours later, which is 4am.
But when I look at her phone in the morning all the carb data from previous day is gone, so no observable carb data from that supper of previous day

@blameitonben
Copy link

blameitonben commented Dec 7, 2022 via email

@flyingpie101
Copy link
Author

That's fair. For me, I could probably come to grips with understanding all the data NS provides.
But until someone reaches that level of understanding of how NS presents its data, I am thinking a user, especially a new or young user, would prefer to view that screen to provide insight into history.
And I would expect that not every looper uses NS (but I hope they do) ;)

@darrelld3
Copy link

darrelld3 commented Dec 7, 2022 via email

@CosiP
Copy link

CosiP commented Dec 8, 2022 via email

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 20, 2023
@marionbarker
Copy link
Contributor

This issue is still of interest. Please leave it open.

@github-actions github-actions bot removed the stale label Jul 30, 2023
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Aug 29, 2023
@marionbarker
Copy link
Contributor

This issue is still of interest and should remain open.

@github-actions github-actions bot removed the stale label Aug 30, 2023
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Sep 29, 2023
@marionbarker
Copy link
Contributor

This is still a desired feature.

@github-actions github-actions bot removed the stale label Sep 30, 2023
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Oct 30, 2023
@marionbarker
Copy link
Contributor

Bump

@github-actions github-actions bot removed the stale label Oct 31, 2023
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 30, 2023
@marionbarker
Copy link
Contributor

Bump

@github-actions github-actions bot removed the stale label Dec 1, 2023
Copy link

github-actions bot commented Jan 1, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jan 1, 2024
@marionbarker
Copy link
Contributor

Bump

@github-actions github-actions bot removed the stale label Jan 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Feb 2, 2024
@marionbarker
Copy link
Contributor

Bump

@github-actions github-actions bot removed the stale label Feb 3, 2024
Copy link

github-actions bot commented Mar 4, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Mar 4, 2024
@marionbarker
Copy link
Contributor

Bump

@github-actions github-actions bot removed the stale label Mar 5, 2024
Copy link

github-actions bot commented Apr 4, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Apr 4, 2024
@marionbarker
Copy link
Contributor

Bump

@github-actions github-actions bot removed the stale label Apr 5, 2024
@oliverstory
Copy link

I think this could be addressed by substituting 'midnight' to an earlier time, e.g. 24 hours prior to 'now', on lines 141-142 in Loop/Loop/View%20Controllers/CarbAbsorptionViewController.swift

        let midnight = Calendar.current.startOfDay(for: Date())
        let listStart = min(midnight, chartStartDate, Date(timeIntervalSinceNow: -deviceManager.carbStore.maximumAbsorptionTimeInterval))

@NightScoutForSeb
Copy link

NightScoutForSeb commented May 2, 2024 via email

@marionbarker
Copy link
Contributor

A customization was added for either 2 full days or 1 week of Carb History (ICE) display.
Once new work on dev proceeds (expect a lot of changes to code so the PR will require an update).
In the meantime:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants