Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report an error of VHS_LoadVideo nodes #240

Open
0filler opened this issue Jun 30, 2024 · 1 comment
Open

Report an error of VHS_LoadVideo nodes #240

0filler opened this issue Jun 30, 2024 · 1 comment

Comments

@0filler
Copy link

0filler commented Jun 30, 2024

Load Video (path&upload) node 3 different Errors:

this old merge works fine
acbf789

from this merge
1ab2027

Error occurred when executing VHS_LoadVideo:

PdhAddEnglishCounterW failed. Performance counters may be disabled.

File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "D:\SD\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 230, in load_video
return load_video_cv(**kwargs)
File "D:\SD\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 144, in load_video_cv
memory_limit = (psutil.virtual_memory().available + psutil.swap_memory().free) - 2 ** 27
File "D:\SD\ComfyUI-aki-v1.3\python\lib\site-packages\psutil_init_.py", line 1992, in swap_memory
return _psplatform.swap_memory()
File "D:\SD\ComfyUI-aki-v1.3\python\lib\site-packages\psutil_pswindows.py", line 257, in swap_memory
percentswap = cext.swap_percent()

then
218658b

Error occurred when executing VHS_LoadVideo:

local variable 'original_gen' referenced before assignment

File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "D:\SD\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 235, in load_video
return load_video_cv(**kwargs)
File "D:\SD\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 164, in load_video_cv
next(original_gen)

and this merge works fine again
1f46b5c

but from this one error again
1c9b635

Error occurred when executing VHS_LoadVideo:

unsupported operand type(s) for //: 'NoneType' and 'float'

File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "D:\SD\ComfyUI-aki-v1.3\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "D:\SD\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 255, in load_video
return load_video_cv(**kwargs)
File "D:\SD\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 156, in load_video_cv
max_loadable_frames = int(memory_limit//(widthheight3*(.1)))

to the newest, same error
7649d51

Disabled all other custom nodes no help. But works fine on my another PC.
So I can still use this custom nodes fine. Just wondering if this can help you troubleshooting.
Thanks for your hard work.

AustinMroz added a commit that referenced this issue Jun 30, 2024
The safety code to ignore the memory limit when it could not be
calculated was incorrectly applied after adding the vae changes.

They have been reapplied. See #240
@AustinMroz
Copy link
Collaborator

Thanks for the report. It should be fixed once more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants