Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisted items are not blacklisted in attachments and magazines #25

Open
Wyqer opened this issue Dec 5, 2018 · 0 comments
Open

Blacklisted items are not blacklisted in attachments and magazines #25

Wyqer opened this issue Dec 5, 2018 · 0 comments
Labels
Milestone

Comments

@Wyqer
Copy link
Member

Wyqer commented Dec 5, 2018

Bug report

Basic Information

KPCF Version: 1.1.0

Individual Things

Did you edit anything within the script files?
Yes

If yes, what did you edit exactly?
Added it to our Liberation version for our wednesday sessions.
Moved the config in the KPCF folder and adjusted the paths accordingly.
Also changed the config values for the KPCF base classname and disabled crate spawning.

Short Issue Description

When selecting a weapon and then magazine or attachments as sub-category, it'll display also items which are blacklisted in the config.

Expected Behaviour

The blacklist should apply for every kind of category/sub-category.

Steps to Reproduce the Issue

  • Add in the blacklist as example the "optic_nightstalker"
  • Start the mission and go to your KPCF Base Object
  • Open Dialog
  • Select any weapon which would be compatible with the Nightstalker optic
  • As sub-category select attachments
  • In the list you'll see the optic, even if it's inside the blacklist

Screenshots, Serverlog or any other helpful Information

Was quite easy to solve on my end, but I wanted to report it.
https://github.com/KillahPotatoes/dubjunks-scripts/blob/master/KP-Cratefiller/KPCF/fnc/fn_createSubList.sqf#L49
Adding before the sorting:

_magazines = _magazines - KPCF_blacklistedItems;

https://github.com/KillahPotatoes/dubjunks-scripts/blob/master/KP-Cratefiller/KPCF/fnc/fn_createSubList.sqf#L66
Adding before the sorting:

_attachments = _attachments - KPCF_blacklistedItems;
@Dubjunk Dubjunk added the Bug label Dec 5, 2018
@Dubjunk Dubjunk added the Backlog label May 1, 2019
@Dubjunk Dubjunk added this to the KPCF v1.2.0 milestone May 1, 2019
@Dubjunk Dubjunk removed the Backlog label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants