Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloading constructors #157

Open
cscherrer opened this issue Sep 2, 2021 · 0 comments
Open

Overloading constructors #157

cscherrer opened this issue Sep 2, 2021 · 0 comments

Comments

@cscherrer
Copy link
Collaborator

I know this isn't part of this PR, but overloading constructors to construct something else can cause problems, the simplest being that something like StudentT(0, 1, 30) isa StudentT is false.

Originally posted by @sethaxen in #156 (comment)

My response:

Yeah, I agree that's a little weird. But the upside is pretty huge. This approach allows us to fine-tune code for Affine, and have that same code work for multivariate-anything. So implementing MvNormal gives us MvStudentT etc for free.

To me it seems worth it, but if you disagree we should talk through it

Let's discuss...

@cscherrer cscherrer mentioned this issue Sep 2, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant