Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for a Release...Soon! #27

Open
CodeforEvolution opened this issue Aug 21, 2020 · 5 comments
Open

Prepare for a Release...Soon! #27

CodeforEvolution opened this issue Aug 21, 2020 · 5 comments

Comments

@CodeforEvolution
Copy link
Contributor

Now that the application is functional again (with some more functionality too), it’s time to prepare for a release! We’ll also want to update the Haiku Ports recipe to drop the dependency of libxml2, since we parse json only now!

@humdingerb
Copy link
Member

Let's wait a few more days. On IRC @Vidrep mentioned a few crashes that appeared after the latest changes. Maybe he'll file a ticket and they might be fixed before a release.

@CodeforEvolution
Copy link
Contributor Author

Ah, I see, well I’ll keep my eyes open for more tickets! (I may have experienced a crash or two while cleaning up the code too, I just decided that I would wait until the code was clean first...but then I forgot about how to reproduce the crash😅)

@CodeforEvolution CodeforEvolution changed the title Prepare for a Release! Prepare for a Release...Soon! Aug 22, 2020
@kenmays
Copy link

kenmays commented Oct 13, 2020

@CodeforEvolution - The current commit works but has a crash when switching channels. I tried a build of your crashEtClean patched branch (#34) but ran into the issue below (hrev54643).
g++ -c HttpUtils.cpp -I./ -Iobjects.x86-cc2-release/ -I- -I/boot/system/develop/headers/private/media -I/boot/system/develop/headers/private/media/experimental -I/boot/system/develop/headers/private/shared -O3 -Wall -Wno-multichar -Wno-ctor-dtor-privacy -o "objects.x86-cc2-release/HttpUtils.o" /boot/system/develop/headers/os/net/HttpRequest.h: In method HttpRequest::HttpRequest(const BUrl &, bool = false, const char * = "HTTP", BUrlProtocolListener * = 0, BUrlContext * = 0)':
In file included from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.cpp:22:
/boot/system/develop/headers/os/net/HttpRequest.h:68: BHttpRequest::BHttpRequest(const BUrl &, bool = false, const char * = "HTTP", BUrlProtocolListener * = 0, BUrlContext * = 0)' is private /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.h:35: within this context /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.cpp: At top level: /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.cpp:83: warning: class HttpIOReader' has virtual functions but non-virtual destructor
/boot/system/develop/headers/os/net/HttpRequest.h: In method HttpRequest::HttpRequest(const BUrl &, bool = false, const char * = "HTTP", BUrlProtocolListener * = 0, BUrlContext * = 0)': In file included from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/Station.h:30, from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/RadioSettings.h:25, from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/MainWindow.h:31, from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/RadioApp.h:24, from /sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/About.cpp:31: /boot/system/develop/headers/os/net/HttpRequest.h:68: BHttpRequest::BHttpRequest(const BUrl &, bool = false, const char * = "HTTP", BUrlProtocolListener * = 0, BUrlContext * = 0)' is private
/sources/StreamRadio-7c8f73312ba8e560a7660a6223516d8036c6680a/HttpUtils.h:35: within this context
/boot/system/develop/etc/makefile-engine:297: recipe for target 'objects.x86-cc2-release/HttpUtils.o' failed
make: *** [objects.x86-cc2-release/HttpUtils.o] Error 1
make: *** Waiting for unfinished jobs....
/boot/system/develop/etc/makefile-engine:297: recipe for target 'objects.x86-cc2-release/About.o' failed
make: *** [objects.x86-cc2-release/About.o] Error 1
Warning: Command '['bash', '-c', '. /wrapper-script']' returned non-zero exit status 2
Error: Build has failed - stopping.
`

@thaflo
Copy link

thaflo commented Dec 19, 2020

Waiting for the "soon" since a while now :-P
Have the same compile-problems like kenmays.

@humdingerb
Copy link
Member

I think a release only makes sense after that crash is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants