Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nograd #1

Open
willtebbutt opened this issue Sep 1, 2019 · 3 comments
Open

nograd #1

willtebbutt opened this issue Sep 1, 2019 · 3 comments

Comments

@willtebbutt
Copy link
Member

willtebbutt commented Sep 1, 2019 •
edited
Loading

It would be very helpful to have @nograd in this package. Looks like it would introduce an IRTools dependency though. Do we care?

edit: IRTools -> MacroTools
@MikeInnes
Copy link
Member

MikeInnes commented Sep 2, 2019 •
edited
Loading

I'm a bit wary of exposing @nograd because it tends to be overzealous (e.g. adding it to rand causes issues). Would a version that requires a signature be reasonable? Not strongly opposed anyhow.

We already depend on MacroTools; I'd like to remove that eventually but for now it makes no odds.

@willtebbutt
Copy link
Member Author

A version that requires a signature would be preferable imho :) Is this something you've got time to implement?

@MikeInnes
Copy link
Member

Yeah, I can give it a shot at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeInnes @willtebbutt