[HOLD for payment 2024-08-29] [HOLD react-native-web 2584][$500] mWeb - Selecting and copying large name in share code displays remaining name with odd 3 dot position

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->profile->display name and set long first or last name (do not set both first and last name as long)
3. Open settings->share code
4. Double click on name and select the text of display name
5. Using end points, try to extend the name beyond 3 dots
6. Observe that now app displays the remaining name but still displays the 3 dots in previous position

Expected Result:

App should either not allow to extend name to select the full name on drag or should remove the 3 dots if name is extended and rest name is displayed

Actual Result:

App allows to extend name to display remaining name in share code and also keeps the 3 dots in same location on mWeb chrome

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

drag.and.extend.big.name.share.code.mp4

Screen_Recording_20230911_124133_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694106668042179

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fbd69c08b1d03d62

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[ishpaul777]

Proposal

Problem

mWeb - Selecting and copying large name in share code displays remaining name with odd 3 dot position

Root cause

We are limiting the no. of line on Text for Display name. The behaviour of text component is to Scrolling while selecting on chrome and it truncates accordingly.

Changes

We can make the Display Name not selectable, by applying styles - userSelectNone or passing a prop userSelect="none" to text component as we already have a "copy to Clipboard link button" already

[s77rt]

@ishpaul777 Thanks for the proposal. I don't think your RCA is complete. Why the 3 dots do not change position (or get removed) and instead they stay in the same position they initially appeared at.

[s77rt]

I didn't check but initial thought is that the bug is not on Exp/App but in RNW or Chromium.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Although text is clipped and hidden user can still drag the selection cursor down to select the full text and the ellipsis is in the middle of the text.

What is the root cause of that problem?

ATM, we use numberOfLines to truncate the text there. When numberOfLines is 1, it uses automatic ellipsis with text-overflow: ellipsis When numberOfLines is larger than 1, it uses fragmenting overflow with -webkit-line-clamp. In the QR share page, we uses numberOfLines=2.

The problem with -webkit-line-clamp is that it does not actually "truncate" the text but inserts an ellipsis in the last position of the specified line (reference). That explains why the ellipsis always stays at the same position. And when we select the text, it would scroll down to select the whole text. We could easily see this (the text was not truncated) by using DevTools to inspect the div.

Another problem is with overflow: hidden. Although it prevents scrolling interface, the wrapper box is still a scroll container and it still allows programmatic scrolling. I think that the dragging cursor to select text in Chrome is somehow related to these two cases.

What changes do you think we should make in order to solve the problem?

Add overflow: clip instead of overflow: hidden to "forbid scrolling entirely, through any mechanism" as mentioned in the document here.

[s77rt]

@tienifr Thanks for the proposal. Your RCA makes sense. Regarding the overflow: hidden, this is added from RNW right? (and not explicitly from the Exp/App). If that's is the case, can you please prepare a RNW PR to update the overflow prop value?

[mallenexpensify]

Unassigning myself as BZ since I was the second one assigned. Let me know if you need help here @johncschuster

[tienifr]

@s77rt Sorry for the delay, I missed the notification on this issue. The style for multiline text is here. And draft PR's here.

[s77rt]

@tienifr Thanks! Can you please update the PR with tests to follow RNW contributing guide

[tienifr]

Once I got assigned, I would submit a complete PR. That's just a draft PR for testing purpose. Correct me if I misunderstood something 🙇

[s77rt]

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

Not overdue. Needs an engineer review here

[tienifr]

@s77rt PR ^

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Multiline Text though clipped can be scrolled into view #47532

If no regressions arise, payment will be issued on 2024-08-29. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @tienifr requires payment through NewDot Manual Requests
• @dhanashree-sawant requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: n/a (upstream bug)
• The offending PR has been commented on: n/a
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No

[dhanashree-sawant]

Hi @johncschuster, is this issue eligible for reporting bonus?

[johncschuster]

It looks like this issue was created September 11, 2023, and we removed the reporting bonus on October 24, 2023. I believe this issue should be eligible for the reporting bonus since it was reported before we removed the bonus.

[johncschuster]

@dhanashree-sawant I've extended an offer to you, here. Can you please accept that?

[dhanashree-sawant]

Thanks @johncschuster, I have accepted the offer.

[johncschuster]

Payment Summary:

Contributor: @tienifr requires payment of $500 through NewDot Manual Requests
Contributor+: @s77rt requires payment of $500 through NewDot Manual Requests

[johncschuster]

I've issued payment to @dhanashree-sawant 🎉
@tienifr and @s77rt, please request payment!

[s77rt]

@johncschuster I was assigned this issue before moving to ND. This one should be paid through Upwork

[johncschuster]

Oh! Thanks for that callout! I'll get a job going in a minute and ping you.

[johncschuster]

Thanks for your patience, @s77rt! Can you please accept the offer, here?

[johncschuster]

Reopening until I've completed payment

[s77rt]

@johncschuster Accepted! Thanks!

[johncschuster]

I've issued payment to @s77rt via Upwork. Thank you all for your contributions! 🎉