Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): replace newSpecPage with newE2EPage #10349

Open
maxpatiiuk opened this issue Sep 19, 2024 · 0 comments
Open

refactor(tests): replace newSpecPage with newE2EPage #10349

maxpatiiuk opened this issue Sep 19, 2024 · 0 comments
Labels
0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.

Comments

@maxpatiiuk
Copy link
Member

Priority impact

p - low

Test type

Unit tests

Which Component(s)

Heading

Unstable Tests

Calcite has 1410 newE2EPage tests and only 2 newSpecPage tests in one file:

https://github.com/Esri/calcite-design-system/blob/7fe16011957a45f3340ba9bfe137bcae258bf314/packages/calcite-components/src/components/functional/Heading.spec.tsx#L2C10-L2C19

To simplify migration, Lumina temporary provides newE2EPage() function that matches Stencil's API. In the long term, it would be great to migrate to Vitest browser test to improve DX, performance and integrations with Storybook.

Given that newSpecPage is only used by Calcite in one file, Lumina doesn't provide Stencil's equivalent of newSpecPage.

TODO:

  • Refactor the usage of newSpecPage in Heading.spec.tsx into newE2EPage

Test error, if applicable

No response

PR skipped, if applicable

Additional Info

No response
@maxpatiiuk maxpatiiuk added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Sep 19, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxpatiiuk