Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for text alternative to be passed into icon in calcite-notice and calcite-alert #10340

Open
2 of 6 tasks
FelFly opened this issue Sep 18, 2024 · 0 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@FelFly
Copy link

FelFly commented Sep 18, 2024

Check existing issues

Summary

As color alone cannot be used to communicate status, our design team typically uses an icon on notices or alerts that belong to kind: success, danger, warning. However, the icon in the notice / alert does not allow us to pass in an accessible label, which was requested on a recent Hub accessibility audit. Our work-around is putting the status into the actual message as a string, but ideally, we'd be able to combine the inclusion of an icon with that status, so that the main message of the component can be consolidated.

Actual Behavior

The icons included on the notices and alerts are set to aria-hidden="true" and we cannot change them.

Screenshot 2024-09-18 at 9 21 06 AM

Screenshot 2024-09-18 at 9 22 37 AM

Screenshot 2024-09-18 at 9 27 14 AM

Expected Behavior

We'd like to be able to pass a simple status label onto icons included in success, danger, and warning style notices and alerts, such as success, warning, error, attention.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/notice/

Reproduction Steps

  1. In either Notice or Alert, set an icon
  2. Navigate component via screen-reader

Reproduction Version

v2.12.2

Working W3C Example/Tutorial

No response

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Hub

@FelFly FelFly added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Sep 18, 2024
@github-actions github-actions bot added ArcGIS Hub Issues logged by ArcGIS Hub team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

1 participant