Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor filtering across components #10328

Open
1 of 5 tasks
geospatialem opened this issue Sep 16, 2024 · 0 comments
Open
1 of 5 tasks

Refactor filtering across components #10328

geospatialem opened this issue Sep 16, 2024 · 0 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@geospatialem
Copy link
Member

Description

We should refactor filtering across components so filtering occurs with the component, and not an external filter component.

cc @driskull

Proposed Advantages

  • Use a component to perform filtering so we can pursue filtering without the UI
  • The debouncing of filtering and bubbling of the filter events can get out of sync, the above approach gives us more support opportunities

Which Component

All components that have filtering, which include:

  • combobox
  • list

Relevant Info

Came up while discussing a long-term approach to accommodate #10230

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@geospatialem geospatialem added refactor Issues tied to code that needs to be significantly reworked. p - low Issue is non core or affecting less that 10% of people using the library 0 - new New issues that need assignment. estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Sep 16, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geospatialem