Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests bug] Incorrect calls to skipAnimations(page); #10326

Open
maxpatiiuk opened this issue Sep 16, 2024 · 0 comments
Open

[Tests bug] Incorrect calls to skipAnimations(page); #10326

maxpatiiuk opened this issue Sep 16, 2024 · 0 comments
Labels
0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Sep 16, 2024

Priority impact

p - low

Test type

End to end tests

Which Component(s)

All

Unstable Tests

In many places in Calcite E2E tests, await skipAnimations(page); is called before page.setContent():

await skipAnimations(page);
await page.setContent(html`

skipAnimations() is adding a <style> tag to the page.

The issue is that page.setContent() clears all other content from the page, thus the <style> tag added by skipAnimations() is removed.

Please review all the places where skipAnimations() is called in such way to check if skipAnimations() is necessary at all (since tests are supposevely working without it?). If it is necessary, then move the call to be after page.setContent().

Test error, if applicable

No response

PR skipped, if applicable

No response

Additional Info

For reference, see the implementation of page.setContent():

https://github.com/ionic-team/stencil/blob/814642f9035df24b1ed45019991542a3fba0884b/src/testing/puppeteer/puppeteer-page.ts#L208

@maxpatiiuk maxpatiiuk added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Sep 16, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Development

No branches or pull requests

1 participant