Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] "content" slot name / description is confusing #10323

Open
macandcheese opened this issue Sep 16, 2024 · 0 comments
Open

[Dialog] "content" slot name / description is confusing #10323

macandcheese opened this issue Sep 16, 2024 · 0 comments
Labels
0 - new New issues that need assignment. docs Issues relating to documentation updates only. needs triage Planning workflow - pending design/dev review.

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Sep 16, 2024

Description

We've received feedback the "content" slot name and description is confusing.

Migrating from Modal - consumers are not changing this to the "default / unnamed" slot and have unexpected results.

Which Component

It's confusing for a few reasons... First, the "content" name is used elsewhere, and it never prevents the rendering of "component chrome" like it does here. Secondly, the description of "A slot for adding custom content." is not descriptive enough.

It should explicitly mention that content in this slot will prevent the rendering of the "component chrome" (except for box-shadow and corner-radius - which may be unexpected).

Because using this slot (the custom one, not the default / recommended one) is a low-occurance use case and the name currently used is so common elsewhere, I'd propose renaming (deprecate + adding replacement) to "custom-content" or something equally as literal, and having the description more clearly outline the behavior when used.

Resources

Feedback received from developer-users within Esri.

@macandcheese macandcheese added docs Issues relating to documentation updates only. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. docs Issues relating to documentation updates only. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

1 participant