Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of SequenceableCollection>>#groupsOf: causes errors #324

Open
Gabriel-Darbord opened this issue Dec 6, 2022 · 1 comment

Comments

@Gabriel-Darbord
Copy link

The extension implementation of SequenceableCollection>>#groupsOf: uses a collection made with self species new to hold groups, however this is problematic when the receiver doesn't support the add: message, such as subclasses of ArrayedCollection.

This method has since been defined in Spec.
Also, I didn't find any sender in the current version of this repo.

Thus, I suggest deleting the method.
Although, if there is still a use for it, relying on Spec will not make it backwards compatible with earlier Pharo versions. Instead, self species new should be replaced with OrderedCollection new.

@jecisc
Copy link
Member

jecisc commented Dec 9, 2022

If the extension is not used in MDL I'll deprecate and remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants