Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more filters from Geonames #415

Open
willdumm opened this issue Apr 9, 2020 · 0 comments · May be fixed by #416
Open

Add support for more filters from Geonames #415

willdumm opened this issue Apr 9, 2020 · 0 comments · May be fixed by #416

Comments

@willdumm
Copy link

willdumm commented Apr 9, 2020

I would like to add support for more geonames filters, specifically 'searchlang'.

This doesn't seem like a difficult task, and there are two obvious approaches:

  1. Include the geonames filters to be added as keys in the set supported_kwargs defined in the GeonamesQuery._build_params method in geonames.py. I took this approach in the pull request below, and all geonames tests still pass.

  2. Stop controlling what filters are passed to the geonames search webservice, and handle any errors that may result from making a request with filters that aren't allowed. This has the advantage that any additions to the geonames api (with respect to search filters) are automatically available as geonames search filters in Geocoder.

As a related note, the geonames support page
has an incomplete list of geonames filters which are supported by Geocoder. The page should make clear that only the filters listed are supported.

@willdumm willdumm linked a pull request Apr 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant