Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic reset for Ephemery Network #8589

Open
gconnect opened this issue Sep 12, 2024 · 3 comments · May be fixed by #8626
Open

Add automatic reset for Ephemery Network #8589

gconnect opened this issue Sep 12, 2024 · 3 comments · May be fixed by #8626
Assignees

Comments

@gconnect
Copy link
Contributor

gconnect commented Sep 12, 2024

Description

Ephemery network have a reset period. As a node runner/validator, I would want my db to be automatically deleted and the update to happen automatically without manually restarting and deleting the old db.

Expected behavior: [What you expect to happen]

  • DB should be automatically deleted when update is due
  • When an update is due config should be updated automatically without manually stopping and restarting
  • Update check should happen on running node and not just on start

Actual behavior: [What actually happens]

  • Manual delete of db
  • Check for update only happens on start.

Frequency: [How regularly does it occur?]
Always

Versions (Add all that apply)

  • Software version: [teku --version or look for log lines starting with Teku version:]
  • Java version: [java -version]
  • OS Name & Version: [cat /etc/*release]
  • Docker Version: [docker version]
  • Cloud VM, type, size: [Amazon Web Services I3-large]
@gconnect
Copy link
Contributor Author

@rolfyone please assign this issue to me and let me know what you think on possible best steps to achieve this.

@rolfyone
Copy link
Contributor

rolfyone commented Sep 12, 2024

I think the easiest will be more like what I had messaged, but to reiterate,

  • firstly on startup, check the fork against the fork of the database, and if it's not matching, rather than fail to start if ephemery, delete the netowrk.yaml and db folder and initialise the database fresh
  • during epoch processing or slot processing, we check the slot is less than the max, otherwise we throw IllegalStateException and let the system crash
  • Then what will happen if its wrapped in a service is it'll automatically restart, and that'll run our startup logic to clean the database...
    i'd see points 1 and 2 as their own PRs for sanity...

@gconnect
Copy link
Contributor Author

I think the easiest will be more like what I had messaged, but to reiterate,

  • firstly on startup, check the fork against the fork of the database, and if it's not matching, rather than fail to start if ephemery, delete the netowrk.yaml and db folder and initialise the database fresh
  • during epoch processing or slot processing, we check the slot is less than the max, otherwise we throw IllegalStateException and let the system crash
  • Then what will happen if its wrapped in a service is it'll automatically restart, and that'll run our startup logic to clean the database...
    i'd see points 1 and 2 as their own PRs for sanity...

Thanks for this. I will look into it.

@gconnect gconnect linked a pull request Sep 21, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants