Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out External signer functionality without using JsonProvider #8527

Open
rolfyone opened this issue Aug 22, 2024 · 0 comments
Open

Build out External signer functionality without using JsonProvider #8527

rolfyone opened this issue Aug 22, 2024 · 0 comments
Assignees
@rolfyone

Comments

@rolfyone
Copy link
Contributor

Primary goal will be removing JsonProvider from being used in ExternalSigner.

This is potentially of use to Web3signer, so if it could be a relatively decoupled module that may be very helpful (they currently use JsonProvider heavily)
@rolfyone rolfyone self-assigned this Aug 22, 2024
rolfyone added a commit to rolfyone/teku that referenced this issue Aug 28, 2024
@rolfyone
Refactored externalSigner to use Typedefs
18209a7 
 - created a new suite of tests to show a number of different signing bodies.
 - had to do manual testing for external signer becuase no AT i think
 - I was able to get from phase0 -> bellatrix so this should cover most scenarios.
 - I believe most of the wrappers should be available in the api

partially addresses Consensys#8527

Signed-off-by: Paul Harris <[email protected]>
@rolfyone rolfyone mentioned this issue Aug 28, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolfyone rolfyone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rolfyone