Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertErrors for several users -- norm(G * v - curr) < 1e-6 check failing #305

Closed
vlandau opened this issue Jul 23, 2021 · 4 comments
Closed

Comments

@vlandau
Copy link
Member

vlandau commented Jul 23, 2021

I've had at least three Omniscape users confront errors related to the @assert norm(G * v - curr) < <some tolerance> check after Circuitscape gets a solution. There are currently two open issues in Omniscape.jl, here, and here. Something must be going on with the solvers that Circuitscape is using. The error occurs regardless of whether the user specifies CG+AMG or CHOLMOD as the solver.

A few things are still needed:

  • Determine if Omniscape is indeed using the CHOLMOD server (there have been reports of that solver not having improved speed over CG+AMG, see issue 101 for Omniscape.jl). In theory because this is a direct solver, shouldn't the matrix norm be 0 (unless it's imperfect due to precision limitations)?
  • Reproduce the error -- a lot of the problems are occurring for very large problems, but presumably only a few actual moving window iterations in Omniscape. I can try to work on reproducing the error for a problem of manageable size

I wanted to open this issue despite the above not being resolved just to get things in motion. Hopefully we can figure this out!

@vlandau
Copy link
Member Author

vlandau commented Jul 26, 2021

Omniscape is indeed correctly using the CHOLMOD solver. Solve times were much faster.

@ranjanan
Copy link
Member

ranjanan commented Aug 5, 2021

@vlandau I just need the files so I can reproduce this issue locally and debug. I have commented on both those threads.

@vlandau
Copy link
Member Author

vlandau commented Aug 6, 2021

Sounds good -- a colleague of mine ran into the same issue as well, so I can also try to track down his inputs. He was out this week but back Monday.

@ranjanan
Copy link
Member

ranjanan commented Aug 9, 2021

Closing this because both related Omniscape issues are now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants