Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Utf8JsonWriter.WriteRawValue instead of JsonSerializer.Serialize #46023

Open
annelo-msft opened this issue Sep 17, 2024 · 1 comment
Open

Use Utf8JsonWriter.WriteRawValue instead of JsonSerializer.Serialize #46023

annelo-msft opened this issue Sep 17, 2024 · 1 comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team System.ClientModel Base Core library

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Sep 17, 2024 •
edited
Loading

In Azure.Core shared source file RequestContentHelper.cs and SCM-based model types, we multitarget and on platforms lower than net6.0, we call JsonSerializer.Serialize instead of Utf8JsonWriter.WriteRawValue.

We should be able to call Utf8JsonWriter.WriteRawValue on all platforms.

@m-nash, @jsquire, @KrzysztofCwalina FYI
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core System.ClientModel Base Core library labels Sep 17, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 17, 2024
@github-actions GitHub Actions
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@annelo-msft annelo-msft removed their assignment Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team System.ClientModel Base Core library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annelo-msft