Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-convergence in the Riemann solver should trigger retry #2924

Open
zingale opened this issue Jul 23, 2024 · 0 comments
Open

non-convergence in the Riemann solver should trigger retry #2924

zingale opened this issue Jul 23, 2024 · 0 comments
Labels

Comments

@zingale
Copy link
Member

zingale commented Jul 23, 2024

at the moment, if we don't converge in the Riemann solver, we abort (on CPUs) or just run with it (on GPUs). We should instead pass out a failure flag and do a retry of the step with a smaller timestep if we didn't converge.

@zingale zingale added the hydro label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant