Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub icons are not legible in dark mode #1350

Open
AleksandrHovhannisyan opened this issue Mar 1, 2022 · 0 comments
Open

GitHub icons are not legible in dark mode #1350

AleksandrHovhannisyan opened this issue Mar 1, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@AleksandrHovhannisyan
Copy link
Contributor

AleksandrHovhannisyan commented Mar 1, 2022

Description

image

image

Steps to reproduce

  1. Visit any page in dark mode.
  2. Observe that the GitHub ::before images are not visible against the dark bg of the docs site.
  3. Related issue: Observe that the text in the "add yours" sidebar wraps awkwardly due to the presence of the icon.

Solution

Not sure... We can do background-color: currentColor on that ::before, but then some of the background clips:

image

It also won't work for light mode.

Another idea was to use a background radial image, but it doesn't seem to be possible to layer that with a background-image without obscuring it, even if we make some parts of the color transparent.

Is there a way to get images without transparency from the API?

@zachleat zachleat added the bug Something isn't working label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants